Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple proxy support to Backplane configuration #344

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

tokalevasant
Copy link
Contributor

@tokalevasant tokalevasant commented Feb 19, 2024

What type of PR is this?

(bug/feature/cleanup/documentation/unit-test)

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves: https://issues.redhat.com/browse/OSD-19785

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@tokalevasant
Copy link
Contributor Author

@supreeth7 made the changes requested. Messed up while squashing so just closed the previous PR and open this one with squashed commits. Also removed the logging as suggested.

@supreeth7
Copy link
Contributor

/retitle Add multiple proxy support to Backplane configuration

@openshift-ci openshift-ci bot changed the title This PR closes OSD-19785. Multiple proxies are saved as array in config file and the first working proxy is used. Add multiple proxy support to Backplane configuration Feb 20, 2024
Copy link
Contributor

@supreeth7 supreeth7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes locally and everything looks good.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supreeth7, tokalevasant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@tokalevasant: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (339c486) 44.04% compared to head (77d1ae7) 44.18%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   44.04%   44.18%   +0.14%     
==========================================
  Files          54       54              
  Lines        4064     4085      +21     
==========================================
+ Hits         1790     1805      +15     
- Misses       2015     2019       +4     
- Partials      259      261       +2     
Files Coverage Δ
cmd/ocm-backplane/config/troubleshoot.go 67.56% <100.00%> (ø)
pkg/cli/config/config.go 72.00% <100.00%> (-0.16%) ⬇️

@openshift-merge-bot openshift-merge-bot bot merged commit bf1c6c3 into openshift:main Feb 20, 2024
7 checks passed
@tokalevasant tokalevasant deleted the OSD-19785 branch February 20, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants