-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not override KUBECONFIG when RunElevate #346
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
+ Coverage 44.18% 45.26% +1.08%
==========================================
Files 54 54
Lines 4085 4204 +119
==========================================
+ Hits 1805 1903 +98
- Misses 2019 2031 +12
- Partials 261 270 +9
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samanthajayasinghe, Tof1973 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Tof1973: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
bug
What this PR does / Why we need it?
When we call RunElevate, it overrides the definition of KUBECONFIG variable to a temporary file which is then deleted, which makes following kube commands to fail as there is no more configuration defined
Which Jira/Github issue(s) does this PR fix?
_Resolves #OSD-21061
Special notes for your reviewer
Once this will be implemented and delivered, osdctl will be updated to remove hack (openshift/osdctl#515)
Pre-checks (if applicable)