Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override KUBECONFIG when RunElevate #346

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Tof1973
Copy link
Contributor

@Tof1973 Tof1973 commented Feb 20, 2024

What type of PR is this?

bug

What this PR does / Why we need it?

When we call RunElevate, it overrides the definition of KUBECONFIG variable to a temporary file which is then deleted, which makes following kube commands to fail as there is no more configuration defined

Which Jira/Github issue(s) does this PR fix?

_Resolves #OSD-21061

Special notes for your reviewer

Once this will be implemented and delivered, osdctl will be updated to remove hack (openshift/osdctl#515)

Pre-checks (if applicable)

  • [ x] Ran unit tests locally
  • [ x] Validated the changes in a cluster
  • [ na] Included documentation changes with PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (faf1879) 44.18% compared to head (882b659) 45.26%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   44.18%   45.26%   +1.08%     
==========================================
  Files          54       54              
  Lines        4085     4204     +119     
==========================================
+ Hits         1805     1903      +98     
- Misses       2019     2031      +12     
- Partials      261      270       +9     
Files Coverage Δ
pkg/elevate/elevate.go 82.45% <55.55%> (-5.30%) ⬇️

... and 1 file with indirect coverage changes

pkg/elevate/elevate.go Show resolved Hide resolved
pkg/elevate/elevate.go Show resolved Hide resolved
@samanthajayasinghe
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samanthajayasinghe, Tof1973

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@Tof1973: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 276d8f0 into openshift:main Feb 20, 2024
7 checks passed
@Tof1973 Tof1973 deleted the OSD-21061 branch February 21, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants