Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitoring-plugin on podman #357

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Mar 3, 2024

What type of PR is this?

bug

What this PR does / Why we need it?

This fixes a bug where if ce.putFileToMount encountered an error, it wouldn't be passed through. This resulted in a situation where the monitoring plugin wouldn't start, but no error would be passed (even with debug).

It also fixes the root bug that was causing ce.putFileToMount to fail. The podman machine ssh command requires the name of the machine you are SSH'ing into to be specified if you are putting an in-line command command.

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2024
Copy link
Contributor

openshift-ci bot commented Mar 3, 2024

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.19%. Comparing base (7340d42) to head (4224117).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   44.18%   44.19%   +0.01%     
==========================================
  Files          54       54              
  Lines        4117     4116       -1     
==========================================
  Hits         1819     1819              
+ Misses       2033     2032       -1     
  Partials      265      265              
Files Coverage Δ
cmd/ocm-backplane/console/console.go 23.31% <33.33%> (+0.03%) ⬆️

@AlexVulaj
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2024
Copy link
Contributor

openshift-ci bot commented Mar 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ba5681c into openshift:main Mar 3, 2024
7 checks passed
@cblecker cblecker deleted the podman-console branch March 3, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants