Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for env KUBE_PS1_CLUSTER_FUNCTION #37

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Added check for env KUBE_PS1_CLUSTER_FUNCTION #37

merged 1 commit into from
Mar 14, 2023

Conversation

reetika-vyas
Copy link
Contributor

@reetika-vyas reetika-vyas commented Mar 13, 2023 •
edited by openshift-ci bot
Loading

What type of PR is this?

feature

What this PR does / Why we need it?

Add check for env KUBE_PS1_CLUSTER_FUNCTION

Which Jira/Github issue(s) does this PR fix?

OSD-14331

Pre-checks (if applicable)

  • [ Yes] Ran unit tests locally
  • [Yes ] Validated the changes in a cluster
  • [ No] Included documentation changes with PR

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@reetika-vyas reetika-vyas marked this pull request as ready for review March 14, 2023 03:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@reetika-vyas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wanghaoran1988
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reetika-vyas, wanghaoran1988

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 34e4c2c into openshift:main Mar 14, 2023
mmazur added a commit to mmazur/ccmux that referenced this pull request Mar 28, 2023
@mmazur
export KUBE_PS1_CLUSTER_FUNCTION
b6717e0 
Required to not get a warning from openshift/backplane-cli#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feichashao feichashao Awaiting requested review from feichashao

@supreeth7 supreeth7 Awaiting requested review from supreeth7

Assignees

@wanghaoran1988 wanghaoran1988

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reetika-vyas @wanghaoran1988 @openshift-merge-robot