Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use md5 hash for session name when assuming Org Role in new backplane flow #385

Merged

Conversation

AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented Apr 1, 2024

What type of PR is this?

feature

What this PR does / Why we need it?

See https://docs.google.com/document/d/1hFlKGy2tInRJwWA28TYEsrTri4CwebVR7TdsG6LmObI/edit

Which Jira/Github issue(s) does this PR fix?

OSD-20300

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

To test locally, find a cluster that uses the new backplane flow, then -

make build
./path/to/new/exec cloud console <cluster_id>

@AlexVulaj
Copy link
Contributor Author

/hold

This needs to wait for a new backplane-api deployment with these changes. We are currently figuring out build issues affecting multiple repositories in this thread.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AlexVulaj
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@hectorakemp
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, hectorakemp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 569cea2 into openshift:main Apr 1, 2024
7 checks passed
@AlexVulaj AlexVulaj deleted the use-md5-assume-org-role branch April 1, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants