Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the timeout to get working proxy url #397

Merged

Conversation

xiaoyu74
Copy link
Contributor

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.61%. Comparing base (c9a5ca4) to head (08a44bb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   44.61%   44.61%           
=======================================
  Files          62       62           
  Lines        5173     5173           
=======================================
  Hits         2308     2308           
  Misses       2548     2548           
  Partials      317      317           
Files Coverage Δ
pkg/cli/config/config.go 75.23% <100.00%> (ø)

@xiaoyu74
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@xiaoyu74 xiaoyu74 force-pushed the increase_getting_proxy_timeout branch from 08a44bb to b900191 Compare April 17, 2024 08:01
@xiaoyu74
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@feichashao
Copy link
Contributor

Adding some context:
2 seconds timeout is not sufficient for a long delay proxy, leading the bp-cli fail to pick a proxy.

This PR serves as a quick fix to unblock the users.

@feichashao
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@xiaoyu74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [feichashao,xiaoyu74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c5f6791 into openshift:main Apr 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants