Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-21438] Remove the fallback to old flow #402

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

xiaoyu74
Copy link
Contributor

What type of PR is this?

(feature)

What this PR does / Why we need it?

Remove fallback to old flow in backplane-cli and return the error

Which Jira/Github issue(s) does this PR fix?

https://issues.redhat.com/browse/OSD-21438

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@xiaoyu74 xiaoyu74 marked this pull request as ready for review April 23, 2024 23:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
@openshift-ci openshift-ci bot requested review from Tafhim and Tessg22 April 23, 2024 23:41
@xiaoyu74
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 45.06%. Comparing base (9569c12) to head (9fbf06a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   44.59%   45.06%   +0.46%     
==========================================
  Files          62       62              
  Lines        5175     5122      -53     
==========================================
  Hits         2308     2308              
+ Misses       2549     2496      -53     
  Partials      318      318              
Files Coverage Δ
cmd/ocm-backplane/cloud/common.go 28.57% <0.00%> (+8.45%) ⬆️

@AlexVulaj
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@xiaoyu74 xiaoyu74 changed the title Remove the fallback to old flow [OSD-21438] Remove the fallback to old flow Apr 24, 2024
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@xiaoyu74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Dee-6777
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, Dee-6777, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Dee-6777
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4ddb43c into openshift:main Apr 25, 2024
7 checks passed
@Dee-6777 Dee-6777 removed their assignment May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants