OSD-22639: prompt, store and reuse elevate reason

[Tof1973]

What type of PR is this?

feature/documentation/unit-test

What this PR does / Why we need it?

OSD-22639

When running ocm-backplate elevate with an empty string as reason, a prompt will be displayed (if possible) to request the reason.
When a reason is provided (as first argument, on prompt or from previous context), it will be stored in cluster context in order that if a reason is needed for elevation within the following 20 min for the same cluster, no prompt will be displayed and the stored context will be used.

Which Jira/Github issue(s) does this PR fix?

Resolves OSD-22639

Special notes for your reviewer

After this change, we will be able to update SOPs using elevate to specify an empty reason, and command will prompt for the reason.

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

[openshift-ci-robot]

@Tof1973: This pull request references OSD-22639 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What type of PR is this?

feature/documentation/unit-test

What this PR does / Why we need it?

OSD-22639

When running ocm-backplate elevate with an empty string as reason, a prompt will be displayed (if possible) to request the reason.
When a reason is provided (as first argument, on prompt or from previous context), it will be stored in cluster context in order that if a reason is needed for elevation within the following 20 min for the same cluster, no prompt will be displayed and the stored context will be used.

Which Jira/Github issue(s) does this PR fix?

Resolves OSD-22639

Special notes for your reviewer

After this change, we will be able to update SOPs using elevate to specify an empty reason, and command will prompt for the reason.

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 62.35294% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 44.57%. Comparing base (51236e1) to head (9b8b250).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   44.74%   44.57%   -0.18%     
==========================================
  Files          62       63       +1     
  Lines        5113     5243     +130     
==========================================
+ Hits         2288     2337      +49     
- Misses       2510     2585      +75     
- Partials      315      321       +6     

Files	Coverage Δ
cmd/ocm-backplane/elevate/elevate.go	66.66% <80.00%> (+66.66%)	⬆️
pkg/elevate/elevate.go	81.96% <66.66%> (-9.70%)	⬇️
pkg/elevate/elevate_context.go	73.80% <73.80%> (ø)
pkg/utils/util.go	45.80% <22.22%> (-3.76%)	⬇️

... and 1 file with indirect coverage changes

[Tof1973]

OSD-22250

[iamkirkbater]

I'll give my +1 to this here - however it will be up to the backplane CLI maintainers to review further and merge.

/lgtm

[samanthajayasinghe]

This is not a blocker, but what if include Elevate section in the readme and document what elevate command does, especially X mins timeouts

[Tof1973]

This is not a blocker, but what if include Elevate section in the readme and document what elevate command does, especially X mins timeouts

I initially have not updated README, as there were no elevate section, but here I created a new dedicated elevate section with all details...

[hectorakemp]

Great work @Tof1973!
All of this makes sense to me - but there's just a few nits in readme related to typos that are simple fixes. I also have tried testing it and can't quite get it to work the way it is expected to in the readme - see this slack thread: https://redhat-internal.slack.com/archives/C016S65RNG5/p1714745369106709?thread_ts=1714393862.376999&cid=C016S65RNG5

[openshift-ci]

@Tof1973: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test build
• /test coverage
• /test images
• /test lint
• /test test

The following commands are available to trigger optional jobs:

• /test scan-optional

Use /test all to run all jobs.

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@Tof1973: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hectorakemp]

/approve

[hectorakemp]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorakemp, iamkirkbater, Tof1973

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hectorakemp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorakemp, iamkirkbater, Tof1973

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hectorakemp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment