Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallbacks to old flow for cloud access #408

Merged

Conversation

AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented May 2, 2024

What type of PR is this?

cleanup

What this PR does / Why we need it?

Currently the bp-cli falls back to the old flow if it fails to assume cloud credentials/console access with the new flow. This was a good fallback initially, but at this point it masks legitimate errors and prevents SREs from knowing what's wrong. This PR removes that fallback in place of passing along logs.

Which Jira/Github issue(s) does this PR fix?

OSD-21438

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

I tested these changes against non-STS clusters, as well as STS clusters using both the old and new flow.

@openshift-ci openshift-ci bot requested review from Dee-6777 and supreeth7 May 2, 2024 16:12
Copy link
Contributor

openshift-ci bot commented May 2, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geowa4
Copy link

geowa4 commented May 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@xiaoyu74
Copy link
Contributor

xiaoyu74 commented May 3, 2024

  • Built a bp-cli binary based on this PR to run towards a previous cluster osd-v4prod-aws (old flow access method) we used to test and the old flow related functions can handle the access properly.

  • Updated if-else block for the 2nd conditions in IsolatedBackplaneAccess looks clear:

	return supportRoleArn.Resource != OldFlowSupportRole, nil
	} else {
		return false, nil
	}

@xiaoyu74
Copy link
Contributor

xiaoyu74 commented May 3, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, geowa4, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 40f88bb into openshift:main May 3, 2024
7 checks passed
@AlexVulaj AlexVulaj deleted the remove-old-flow-fallback branch May 3, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants