Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Update Owner #418

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

feichashao
Copy link
Contributor

What type of PR is this?

cleanup

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@bmeng
Copy link
Contributor

bmeng commented May 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, feichashao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@supreeth7
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 913cce5 and 2 for PR HEAD cb82748 in total

@xiaoyu74
Copy link
Contributor

/retest

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@feichashao: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.57%. Comparing base (913cce5) to head (cb82748).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   44.57%   44.57%           
=======================================
  Files          63       63           
  Lines        5243     5243           
=======================================
  Hits         2337     2337           
  Misses       2585     2585           
  Partials      321      321           

@openshift-merge-bot openshift-merge-bot bot merged commit 1ff1aeb into openshift:main May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants