Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-15452 : Updating Readme #42

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

MitaliBhalla
Copy link
Contributor

@MitaliBhalla MitaliBhalla commented Mar 16, 2023

What type of PR is this?

documentation
(bug/feature/cleanup/documentation)

What this PR does / Why we need it?

This PR intends to update the README for this repository

Which Jira/Github issue(s) does this PR fix?

OSD-15452
Resolves #
OSD-15452

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #42 (f186473) into main (af00235) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   41.95%   41.95%           
=======================================
  Files          33       33           
  Lines        2026     2026           
=======================================
  Hits          850      850           
  Misses       1045     1045           
  Partials      131      131           

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Updating as per changes asked in review
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@supreeth7
Copy link
Contributor

Can you please resolve the comments?

@supreeth7
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MitaliBhalla, supreeth7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit cf34cd3 into openshift:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants