Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-23312: Refactor GetRestConfig() to allow passing an ocm connection programatically #421

Merged
merged 1 commit into from
May 18, 2024

Conversation

typeid
Copy link
Member

@typeid typeid commented May 17, 2024

What type of PR is this?

cleanup

What this PR does / Why we need it?

CAD needs to use the GetRestConfig() function, but it doesn't allow passing an ocmConnection programatically.
To not refactor the whole ocm package/usage, I dupliacted the functions to allow passing and initializing on the fly.

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2024

@typeid: This pull request references OSD-23312 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What type of PR is this?

cleanup

What this PR does / Why we need it?

CAD needs to use the GetRestConfig() function, but it doesn't allow passing an ocmConnection programatically.
To not refactor the whole ocm package/usage, I dupliacted the functions to allow passing and initializing on the fly.

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@typeid typeid force-pushed the OSD-23312_refactor branch 3 times, most recently from 7b55e2d to e868d88 Compare May 17, 2024 15:56
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@typeid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2024
Copy link
Contributor

openshift-ci bot commented May 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7d1525b into openshift:main May 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants