-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for nil ptr proxy-url value in troubleshoot util #436
Check for nil ptr proxy-url value in troubleshoot util #436
Conversation
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 44.51% 45.89% +1.37%
==========================================
Files 63 63
Lines 5284 5731 +447
==========================================
+ Hits 2352 2630 +278
- Misses 2615 2767 +152
- Partials 317 334 +17
|
/lgtm |
@nephomaniac Thank you for fixing this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feichashao, nephomaniac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nephomaniac: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
bug
What this PR does / Why we need it?
Fixes nil pointer deference seg fault during the troubleshoot util
Adds notice in the troubleshoot util for missing config file if not found at the expected path.
Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
This should address the following error when "proxy-url" value is not set in the current configuration file/path, and not provided as an environment var.
Pre-checks (if applicable)