Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-20658] Updated the ci-release script to ensure remote upstream repo is added #452

Merged

Conversation

xiaoyu74
Copy link
Contributor

What type of PR is this?

(bug)

What this PR does / Why we need it?

To ensure remote upstream repo is added based on the job failures logs I got: https://storage.googleapis.com/test-platform-results/logs/branch-ci-openshift-backplane-cli-main-combined-release/1800401130698575872/build-log.txt

Which Jira/Github issue(s) does this PR fix?

https://issues.redhat.com/browse/OSD-20658

@xiaoyu74 xiaoyu74 changed the title Updated the ci-release script to ensure remote upstream repo is added [OSD-20658] Updated the ci-release script to ensure remote upstream repo is added Jun 12, 2024
@openshift-ci openshift-ci bot requested review from bmeng and feichashao June 12, 2024 00:54
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.54%. Comparing base (6075bc8) to head (66fb498).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   44.54%   44.54%           
=======================================
  Files          63       63           
  Lines        5296     5296           
=======================================
  Hits         2359     2359           
  Misses       2617     2617           
  Partials      320      320           

@xiaoyu74
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2024
ci-release.sh Outdated Show resolved Hide resolved
ci-release.sh Outdated Show resolved Hide resolved
@xiaoyu74 xiaoyu74 requested a review from bmeng June 12, 2024 03:08
@xiaoyu74
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2024
ci-release.sh Outdated Show resolved Hide resolved
Update the logic to ensure remote upstream repo is set to correct URL

Remove the token setting and make release
@xiaoyu74 xiaoyu74 requested a review from bmeng June 12, 2024 09:23
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

@xiaoyu74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bmeng
Copy link
Contributor

bmeng commented Jun 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4e62629 into openshift:main Jun 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants