-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSD-19783] Add backplane subcommand to do health check of VPN and proxy #469
[OSD-19783] Add backplane subcommand to do health check of VPN and proxy #469
Conversation
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
========================================
Coverage 45.66% 45.66%
========================================
Files 72 78 +6
Lines 5961 6160 +199
========================================
+ Hits 2722 2813 +91
- Misses 2895 2997 +102
- Partials 344 350 +6
|
bd00543
to
ae50918
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @xiaoyu74 .. It's good if you can add at least 50% unit tests to cover new sub command
/hold |
58f80a5
to
ff801f7
Compare
/unhold |
432510e
to
dac1c9a
Compare
…vity Fixing golang-lint issue Refactor the HealthCheckCmd to move the logic in the Run to a separate func Revert and keep proxyURL field only Refactored code based on the review feedback Added test cases Added some more test cases to improve the coverage Move the main logic to pkg and generate mock files via mockgen Removed the default value of backplane configuration and added debug log Add debug log for cloud console Updated README.md with the healthcheck usage Add utun as for checking VPN connectivity in MacOS
dac1c9a
to
44e9f3f
Compare
@xiaoyu74: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feichashao, xiaoyu74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
(feature)
What this PR does / Why we need it?
Add backplane subcommand to do health check of VPN and proxy connectivity
More discussions in slack
Which Jira/Github issue(s) does this PR fix?
https://issues.redhat.com/browse/OSD-19783
Special notes for your reviewer
1. Latest updates resolved all the review comments - 16 July
pkg
folderMakefile
to usemockgen
to generate mock files with the mock interfaces for the test casesconfig.go
to avoid expose internal URL, allowing the end-user to customize the endpoint URLs in the local backplane configurationVPNCheckEndpoint
ProxyCheckEndpoint
connectivity_checks.go
function intocheck_vpn.go
andcheck_proxy.go
based on the core functionality.check-endpoint
in the local bp configuration, example below:2. Command output examples
VPN or Proxy
connectivity respectively by specifying the--vpn
or--proxy
flag