Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-24269: Add cluster login support via OHSS card #478

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

samanthajayasinghe
Copy link
Contributor

What type of PR is this?

feature

What this PR does / Why we need it?

Login cluster via JIRA ID

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot requested review from bmeng and mjlshen July 10, 2024 05:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 20 lines in your changes missing coverage. Please review.

Project coverage is 45.71%. Comparing base (5cbc36d) to head (252cbea).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   45.50%   45.71%   +0.20%     
==========================================
  Files          71       72       +1     
  Lines        5900     5954      +54     
==========================================
+ Hits         2685     2722      +37     
- Misses       2878     2888      +10     
- Partials      337      344       +7     
Files Coverage Δ
pkg/accessrequest/accessRequest.go 66.44% <100.00%> (ø)
pkg/jira/issueService.go 0.00% <ø> (ø)
pkg/jira/mocks/jiraMock.go 100.00% <ø> (ø)
pkg/jira/ohssService.go 70.96% <70.96%> (ø)
cmd/ocm-backplane/login/login.go 68.24% <57.69%> (-0.21%) ⬇️

@samanthajayasinghe samanthajayasinghe marked this pull request as draft July 10, 2024 05:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@samanthajayasinghe samanthajayasinghe marked this pull request as ready for review July 11, 2024 02:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@samanthajayasinghe samanthajayasinghe changed the title Add Jira login support OSD-24269: Add cluster login support via OHSS card Jul 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024

@samanthajayasinghe: This pull request references OSD-24269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

What type of PR is this?

feature

What this PR does / Why we need it?

Login cluster via JIRA ID

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@samanthajayasinghe samanthajayasinghe force-pushed the jira-client branch 3 times, most recently from 455a139 to b616ac9 Compare July 12, 2024 04:57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test leftovers :)

@feichashao
Copy link
Contributor

feichashao commented Jul 12, 2024

I hit an error,

 ./ocm-backplane login --ohss OHSS-xxxxx 
ERRO[0008] issue OHSS-xxxx is not belongs to OHSS project 

let me send you the OHSS ticket number offline.

@samanthajayasinghe
Copy link
Contributor Author

I hit an error,

 ./ocm-backplane login --ohss OHSS-xxxxx 
ERRO[0008] issue OHSS-xxxx is not belongs to OHSS project 

let me send you the OHSS ticket number offline.

ahh ..nasty last-minute refactor mistake :(
Should be fixed now

@feichashao
Copy link
Contributor

/label tide/merge-method-squash
/lgtm

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [feichashao,samanthajayasinghe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1699359 into openshift:main Jul 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants