Fix upgrade and version check #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2023 18:05
Fix versioning
openshift-ci
bot
added
the
approved
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
|
@supreeth7: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: supreeth7, wanghaoran1988 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
What this PR does / Why we need it?
This PR fixes how we fetch binaries for upgrades and well as enforces the
versionof backplane CLI to not be static.Which Jira/Github issue(s) does this PR fix?
https://issues.redhat.com/browse/OSD-15761
Special notes for your reviewer
Instructions to test
versionis not static anymore and is populated by goreleaser's build dynamically upon each release based on tags.goreleaser build --skip-validate. This will generate the release artifacts in thedist/folder../dist/ocm-backplane_linux_amd64_v1/ocm-backplane upgradeor./dist/ocm-backplane_linux_amd64_v1/ocm-backplane version.Pre-checks (if applicable)