Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers to obtain an aws-sdk-go-v2 client for programmatic access #66

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Apr 5, 2023

What type of PR is this?

feature

What this PR does / Why we need it?

This allows other tools to get an AWS client and programatically interact with the AWS API. osdctl used to do this with the previous iteration of backplane-api and these helpers would assist with the effort in openshift/osdctl#357 instead of having to re-implement a lot of the parsing logic.

Signed-off-by: Michael Shen <mshen@redhat.com>
@wanghaoran1988
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, wanghaoran1988

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #66 (520f293) into main (6e95b55) will increase coverage by 0.92%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   43.90%   44.82%   +0.92%     
==========================================
  Files          37       37              
  Lines        2182     2224      +42     
==========================================
+ Hits          958      997      +39     
- Misses       1082     1083       +1     
- Partials      142      144       +2     
Impacted Files Coverage Δ
cmd/ocm-backplane/cloud/credentials.go 66.15% <0.00%> (-12.03%) ⬇️

... and 3 files with indirect coverage changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants