Skip to content

Conversation

@T0MASD
Copy link

@T0MASD T0MASD commented Aug 11, 2025

with this change testHTTPRequestToBackplaneAPI, checks that when used, proxy url starts with http and does proxy hostname dns lookup to confirm connectivity so user can clearly spot if there's an issue with config or connectivty

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: T0MASD
Once this PR has been reviewed and has the lgtm label, please assign smarthall for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@bbcffa9). Learn more about missing BASE report.
⚠️ Report is 98 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage        ?   53.29%           
=======================================
  Files           ?       86           
  Lines           ?     7104           
  Branches        ?        0           
=======================================
  Hits            ?     3786           
  Misses          ?     2849           
  Partials        ?      469           
Files with missing lines Coverage Δ
pkg/cli/config/config.go 86.94% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@T0MASD T0MASD force-pushed the update_checking_request_to_backplane branch 2 times, most recently from fa622d3 to 48e749a Compare August 11, 2025 18:11
@samanthajayasinghe
Copy link
Contributor

Thanks for the PR @T0MASD ,
Please follow the PR guidelines next time as best practice.

@T0MASD
Copy link
Author

T0MASD commented Aug 12, 2025

/hold
while I update the commit message

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
…roxy hostname dns lookup to confirm connectivity
@T0MASD T0MASD force-pushed the update_checking_request_to_backplane branch from 48e749a to c70609e Compare August 13, 2025 07:50
@T0MASD T0MASD changed the title check that when used, proxy url starts with http and do proxy hostname dns lookup to confirm connectivity [SREP-1559] check that when used, proxy url starts with http and do proxy hostname dns lookup to confirm connectivity Aug 13, 2025
@T0MASD
Copy link
Author

T0MASD commented Aug 13, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@T0MASD
Copy link
Author

T0MASD commented Aug 13, 2025

/hold while I fix race condition in a test

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@feichashao feichashao changed the title [SREP-1559] check that when used, proxy url starts with http and do proxy hostname dns lookup to confirm connectivity [SREP-1559] feat: check that when used, proxy url starts with http and do proxy hostname dns lookup to confirm connectivity Aug 14, 2025
@samanthajayasinghe
Copy link
Contributor

/test all

@samanthajayasinghe
Copy link
Contributor

@T0MASD seems all tests are fine , do you need adjust more tests ?

@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Nov 6, 2025

/test all

@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Nov 6, 2025

/test images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@T0MASD: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants