-
Notifications
You must be signed in to change notification settings - Fork 79
[SREP-1559] feat: check that when used, proxy url starts with http and do proxy hostname dns lookup to confirm connectivity #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: T0MASD The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage ? 53.29%
=======================================
Files ? 86
Lines ? 7104
Branches ? 0
=======================================
Hits ? 3786
Misses ? 2849
Partials ? 469
🚀 New features to boost your workflow:
|
fa622d3 to
48e749a
Compare
|
Thanks for the PR @T0MASD , |
|
/hold |
…roxy hostname dns lookup to confirm connectivity
48e749a to
c70609e
Compare
|
/unhold |
|
/hold while I fix race condition in a test |
|
/test all |
|
@T0MASD seems all tests are fine , do you need adjust more tests ? |
|
/test all |
|
/test images |
|
@T0MASD: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
with this change testHTTPRequestToBackplaneAPI, checks that when used, proxy url starts with http and does proxy hostname dns lookup to confirm connectivity so user can clearly spot if there's an issue with config or connectivty