Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPNET-629: Use HAProxy monitor endpoint instead of API #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cybertron
Copy link
Member

This is the runtimecfg change corresponding to
openshift/machine-config-operator#4767
which switches the monitor call to the HAProxy endpoing rather than
call through to the API.

I also included a commit to bump the Dockerfile image to golang 1.22 to match the current state of the code.

We've moved the code to 1.22 so the 1.21 image no longer works.
This is the runtimecfg change corresponding to
openshift/machine-config-operator#4767
which switches the monitor call to the HAProxy endpoing rather than
call through to the API.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2024

@cybertron: This pull request references OPNET-629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This is the runtimecfg change corresponding to
openshift/machine-config-operator#4767
which switches the monitor call to the HAProxy endpoing rather than
call through to the API.

I also included a commit to bump the Dockerfile image to golang 1.22 to match the current state of the code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@cybertron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d4bd2f3 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants