Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options of github endpoints to auto-tools #172

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Add options of github endpoints to auto-tools #172

merged 1 commit into from
Sep 23, 2019

Conversation

hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Sep 20, 2019

Add options of github endpoints to auto-tools

With the option we can use ghproxy service and get metrics.

For the existing prwo jobs using those tools, we need to update the args accordingly.

/cc @openshift/openshift-team-developer-productivity-test-platform

@openshift-ci-robot openshift-ci-robot requested a review from a team September 20, 2019 19:35
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2019
With the option we can use ghproxy service and get metrics.

For the existing prwo jobs using those tools, we need to update the
args accordingly.
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hongkailiu,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7be3126 into openshift:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants