Make rehearsals of hidden jobs have skip_report: true
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is deprecaded, and also unable to make a diff of the current form of the `Presubmit` struct, which contains unexported fields. This caused failing tests to end with a panic instead of producing a readable diff.
Rehearsals of hidden jobs are also hidden jobs, but they are "special" by being hidden jobs on a repository that should not have hidden jobs (openshift/release). This causes problems because the config makes jobs on `openshift/release` to have URLs in GH to the public Deck/Spyglass instance, but that instance does not have access to the underlying private storage so it cannot show the rehearsal's logs and artifacts. Additionally, whoever triggers a rehearsal of a hidden job is unlikely to have access to the Deck instance that shows hidden jobs, so they would not be able to access the logs even if the URL were correct. Therefore, we make such jobs skip reporting to GH to avoid confusion Note: "hidden" means the Deck concept of hidden jobs
openshift-ci-robot
added
size/XL
|
/cc @openshift/openshift-team-developer-productivity-test-platform |
droslean
approved these changes
Jan 8, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rehearsals of hidden jobs are also hidden jobs, but they are "special"
by being hidden jobs on a repository that should not have hidden
jobs (openshift/release). This causes problems because the config makes
jobs on
openshift/releaseto have URLs in GH to the public Deck/Spyglassinstance, but that instance does not have access to the underlying private
storage so it cannot show the rehearsal's logs and artifacts.
(see the
ci/rehearse/openshift-priv/ci-experiment-origin/master/e2e-cmdrehearsal on openshift/release#6536 for an example)
Additionally, whoever triggers a rehearsal of a hidden job is unlikely to
have access to the Deck instance that shows hidden jobs, so they would not
be able to access the logs even if the URL were correct.
Therefore, we make such jobs skip reporting to GH to avoid confusion
Note: "hidden" means the Deck concept of hidden jobs
Additionally, I discovered the current tests panic when they fail because
diff.Object*Diff(deprecated anyway) do not handle unexported fields, so I ported the tests tocmp.Diff. Also, spotted some dead code in those tests and removed it./cc @openshift/openshift-team-developer-productivity-platform