Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channels/stable-4.8: Remove filter to include 4.7.z #1075

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

wking
Copy link
Member

@wking wking commented Sep 20, 2021

Generated with:

$ sed -i '/^  filter: /d' channels/stable-4.8.yaml
$ hack/stabilization-changes.py

but using the still-in-flight version of that script from #1039 to include the promotions in this commit, so the stabilization bot doesn't follow up with a whole bunch of parallel promotion pull requests.

We've been cooking in fast-4.8 long enough that we feel fairly confident that major 4.7 -> 4.8 issues will have surfaced by now.

Generated with:

  $ sed -i '/^  filter: /d' channels/stable-4.8.yaml
  $ hack/stabilization-changes.py

but using the still-in-flight version of that script from [1] to
include the promotions in this commit, so the stabilization bot
doesn't follow up with a whole bunch of parallel promotion pull
requests.

We've been cooking in fast-4.8 long enough that we feel fairly
confident that major 4.7 -> 4.8 issues will have surfaced by now.

[1]: openshift#1039
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@wking
Copy link
Member Author

wking commented Sep 20, 2021

Waiting for @sdodson to sign off.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@sdodson
Copy link
Member

sdodson commented Sep 21, 2021

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@sdodson
Copy link
Member

sdodson commented Sep 21, 2021

/test e2e

@openshift-merge-robot openshift-merge-robot merged commit c7820dc into openshift:master Sep 21, 2021
@wking wking deleted the stable-4.7-to-4.8 branch September 21, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants