channels: Add 4.2.16+amd64 back to candidate-4.3 and fast-4.3 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once a node enters a channel, we don't want to remove it. Doing so would leave existing residents in that channel with the VersionNotFound error out of the cluster-version operator. Restore 4.2.16+amd64 to the channels it was in before c22d57e (blocked-edges: Block edges for storage.conf machine-config bug, 2020-02-19, #59), and rely on blocked-edges alone (also from c22d57e) to keep 4.2.16 -> 4.3.0 out of the graph. Folks on 4.2.16 in candidate-4.3 or fast-4.3 will now be suggested to take the 4.2.16 -> 4.2.18 -> 4.3.1 pathway into 4.3.
openshift-ci-robot
added
the
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
referenced
this pull request
in wking/cincinnati-graph-data
Mar 31, 2020
It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable. * 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d (Merge pull request #73 from wking/4.2.16-to-fast-4.3, 2020-02-21). * There was no 4.2.17 (no releases in the week after 4.2.16). * 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4 (Merge pull request #60 from wking/fast-4.2.18, 2020-02-20). * 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05 (Merge pull request #64 from thiagoalessio/fast-4.2, 2020-02-24). The previous comments about "only valid into" were from 505f7a6 (Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear on the motivation.
sdodson
pushed a commit
to sdodson/cincinnati-graph-data
that referenced
this pull request
Apr 16, 2020
It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable. * 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21). * There was no 4.2.17 (no releases in the week after 4.2.16). * 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4 (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20). * 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05 (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24). The previous comments about "only valid into" were from 505f7a6 (Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear on the motivation.
sdodson
pushed a commit
to sdodson/cincinnati-graph-data
that referenced
this pull request
Jul 14, 2020
It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable. * 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21). * There was no 4.2.17 (no releases in the week after 4.2.16). * 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4 (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20). * 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05 (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24). The previous comments about "only valid into" were from 505f7a6 (Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear on the motivation.
sdodson
pushed a commit
to sdodson/cincinnati-graph-data
that referenced
this pull request
Jul 29, 2020
It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable. * 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21). * There was no 4.2.17 (no releases in the week after 4.2.16). * 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4 (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20). * 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05 (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24). The previous comments about "only valid into" were from 505f7a6 (Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear on the motivation.
sdodson
pushed a commit
to sdodson/cincinnati-graph-data
that referenced
this pull request
Aug 24, 2020
It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable. * 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21). * There was no 4.2.17 (no releases in the week after 4.2.16). * 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4 (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20). * 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05 (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24). The previous comments about "only valid into" were from 505f7a6 (Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear on the motivation.
sdodson
pushed a commit
to sdodson/cincinnati-graph-data
that referenced
this pull request
Dec 3, 2020
It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable. * 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21). * There was no 4.2.17 (no releases in the week after 4.2.16). * 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4 (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20). * 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05 (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24). The previous comments about "only valid into" were from 505f7a6 (Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear on the motivation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a node enters a channel, we don't want to remove it. Doing so would leave existing residents in that channel with the
VersionNotFounderror out of the cluster-version operator. Restore 4.2.16+amd64 to the channels it was in before c22d57e (#59), and rely onblocked-edgesalone (also from c22d57e) to keep 4.2.16 -> 4.3.0 out of the graph.Folks on 4.2.16 in candidate-4.3 or fast-4.3 will now be suggested to take the 4.2.16 -> 4.2.18 -> 4.3.1 pathway into 4.3.