Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prerelease-4.1: add 4.1.37 #91

Merged
merged 1 commit into from
Mar 6, 2020
Merged

prerelease-4.1: add 4.1.37 #91

merged 1 commit into from
Mar 6, 2020

Conversation

vfreex
Copy link
Contributor

@vfreex vfreex commented Mar 5, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2020
@vrutkovs
Copy link
Member

vrutkovs commented Mar 5, 2020

/hold

CI data at https://openshift-release.svc.ci.openshift.org/releasestream/4-stable/release/4.1.37 shows 5/7 updates have failed

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2020
@vrutkovs
Copy link
Member

vrutkovs commented Mar 5, 2020

Filed https://bugzilla.redhat.com/show_bug.cgi?id=1810480. Although this test fails often during upgrade (70% of cases) its has been plaguing previous releases too - 57% of upgrades in 4.1.31

@vrutkovs
Copy link
Member

vrutkovs commented Mar 5, 2020

/approve
/lgtm

Known issue, most likely would be wontfixed by api-server team.

/cc eparis

Feel free to cancel the hold when ready

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@LalatenduMohanty
Copy link
Member

#98 Adding 4.1.37 to candidate 4.2 channel

@eparis
Copy link
Member

eparis commented Mar 6, 2020

/approve
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, vfreex, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 49baa37 into openshift:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@steveej steveej Awaiting requested review from steveej

@eparis eparis Awaiting requested review from eparis

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vfreex @vrutkovs @LalatenduMohanty @eparis @openshift-ci-robot @openshift-merge-robot