.gitignore: Drop auto-generated content #60
Conversation
From [1]:
Which file to place a pattern in depends on how the pattern is meant to be used.
* Patterns which should be version-controlled and distributed to
other repositories via clone (i.e., files that all developers will
want to ignore) should go into a .gitignore file.
...
* Patterns which a user wants Git to ignore in all situations (e.g.,
backup or temporary files generated by the user's editor of
choice) generally go into a file specified by core.excludesFile in
the user's ~/.gitconfig. Its default value is
$XDG_CONFIG_HOME/git/ignore. If $XDG_CONFIG_HOME is either not set
or empty, $HOME/.config/git/ignore is used instead.
So editor files are not appropriate for the project's
versioned-controlled .gitignore. We could keep the Go stuff, but it's
not clear to me if we have tooling that generates any of those outside
of the temporary build directories which already have manually-curated
.gitignore entries.
[1]: https://git-scm.com/docs/gitignore#_description
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci-robot
added
lifecycle/rotten
channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to fast-4.3)
Expanding on the link from b1465b7 (Information on why 4.3.2 and 4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87). Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels, 2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates, since those are the only transitions where manifests dropped container ports [1]. Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug. 4.2 -> 4.3.1 had been blocked before, although that block was lifted in c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to fast-4.3), 2020-02-19, openshift#60). I think 1161d00's broader .* blocks (which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were because the Multus bug affects all updates, but, as explained in a5f394d (blocked-edges/4.3.*: Drop references to Multus bug 1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update blocker. Also, no need to talk about these in the channel YAML files, since we aren't tombstoning the releases (we discovered the bug after marking the releases supported by tagging them into fast channels). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable. * 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21). * There was no 4.2.17 (no releases in the week after 4.2.16). * 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4 (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20). * 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05 (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24). The previous comments about "only valid into" were from 505f7a6 (Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear on the motivation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
Gitignore change unrelated to broken e2e. /override ci/prow/operator-e2e |
|
@wking: Overrode contexts on behalf of wking: ci/prow/operator-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test images |
|
/override ci/prow/images But we'll need to dig into why these are repeatedly failing. |
|
@wking: Overrode contexts on behalf of wking: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From the docs:
So editor files are not appropriate for the project's versioned-controlled
.gitignore. We could keep the Go stuff, but it's not clear to me if we have tooling that generates any of those outside of the temporary build directories which already have manually-curated.gitignoreentries.