-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWNERS: Bugzilla product should be "OpenShift Update Service" #77
OWNERS: Bugzilla product should be "OpenShift Update Service" #77
Conversation
Based on Scott's [1]: > It's used downstream to facilitate mapping to BZ Components. I'm not sure if this property matters to us, because we are a separate Red Hat product, not a component under the OpenShift Container Project product. But 'Cincinnati Operator' no longer exists anywhere, so pointing folks at our current product name isn't breaking it any worse. $ curl -s 'https://bugzilla.redhat.com/rest/product/OpenShift%20Update%20Service' | jq -r '.products[].name' OpenShift Update Service $ curl 'https://bugzilla.redhat.com/rest/product/Cincinnati%20Operator' {"products":[]} [1]: openshift/cluster-version-operator#344 (comment)
24845f6
to
727a3c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'd updated the value in 727a3c5 (OWNERS: Bugzilla product should be "OpenShift Update Service", 2020-11-10, openshift#77), but at that point I was uncertain about how to handle Bugzilla products vs. components. Today, Luke pointed me towards the consuming code [1], showing that we should have used the 'product' key, overriding ART's "OpenShift Container Platform" default product. [1]: https://github.com/openshift/doozer/blob/231d240702a5c22da488fa241bc76df416acee6a/doozerlib/metadata.py#L288-L343
I'd updated the value in 727a3c5 (OWNERS: Bugzilla product should be "OpenShift Update Service", 2020-11-10, openshift#77), but at that point I was uncertain about how to handle Bugzilla products vs. components. Today, Luke pointed me towards the consuming code [1], showing that we should have used the 'product' key, overriding ART's "OpenShift Container Platform" default product. [1]: https://github.com/openshift/doozer/blob/231d240702a5c22da488fa241bc76df416acee6a/doozerlib/metadata.py#L288-L343
Based on @sdodson's comment:
I'm not sure if this property matters to us, because we are a separate Red Hat product, not a component under the OpenShift Container Project product. But
Cincinnati Operator
no longer exists anywhere, so pointing folks at our current product name isn't breaking it any worse.