Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift_secondary_metadata_parser: Accept graph-data 1.1.0 #539

Merged

Conversation

wking
Copy link
Member

@wking wking commented Sep 21, 2021

Backporting #538 to 4.9.

Ideally this would be parsed as SemVer with appropriate compatability
resolution (minor bumps are backwards compatible [1]).  But doing that
in Rust in a few minutes is beyond my abilities.  This temporary hack
unblocks the 1.1.0 graph-data migration, avoiding:

  2021-09-21T13:09:26Z ERROR graph_builder::graph] unrecognized graph-data version 1.1.0
    ; supported versions: ["1.0.0"]

until we can get that SemVer parser in place.

[1]: https://semver.org/spec/v2.0.0.html#spec-item-7
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

@wking: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

openshift_secondary_metadata_parser: Accept graph-data 1.1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 30b6994 into openshift:release-4.9 Sep 21, 2021
@wking wking deleted the accept-graph-data-1.1.0 branch September 22, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants