[WIP] graph-builder: add dynamic plugins configuration #74
Conversation
This updates the logic for reading credentials, getting rid of Option handling and using generic path references instead.
This adds support to instanciate plugins with custom configuration. In particular, it adds methods to validate and fill-in user configuration, and to build plugin instances from valid settings. It also add a static registry to look them up by name.
This add aliases for CLI options currently used in deployments, to make migrations easier. It can be dropped/reverted at a later point.
This adds some temporary hardcoded configuration for plugins, for compatibility purposes and to ease migration of existing deployment. It can be dropped at a later point.
This updates cincinnati pod definition with newer CLI options names.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
| @@ -4,7 +4,9 @@ | |||
| pub mod external; | |||
| pub mod interface; | |||
| pub mod internal; | |||
| mod registry; | |||
There was a problem hiding this comment.
we lost a note on the way discussing this name. I suggest one of:
- catalog
- index
There was a problem hiding this comment.
I'm +1 on catalog, will rename on next rebase.
|
@lucab: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
@lucab: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@steveej: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.