Skip to content

Conversation

@dusk125
Copy link

@dusk125 dusk125 commented Nov 14, 2024

  • need to remove mod replace

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2024

@dusk125: This pull request references CNTRLPLANE-3 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@dusk125
Copy link
Author

dusk125 commented Nov 14, 2024

/assign @bertinatto

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2024

@dusk125: This pull request references CNTRLPLANE-3 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

  • need to remove mod replace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2024
@dusk125 dusk125 force-pushed the k8s-1.32 branch 4 times, most recently from 2e9177b to 9d86edf Compare December 12, 2024 05:49
@JoelSpeed
Copy link
Contributor

Could we please separate the manual changes from the generated/vendor changes and commit them separately, I cannot load this PR to review what's changed at the moment 😓

@dusk125 dusk125 force-pushed the k8s-1.32 branch 2 times, most recently from 74f573c to 42130f1 Compare January 24, 2025 23:07
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2025

@dusk125: This pull request references CNTRLPLANE-3 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

  • need to remove mod replace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125 dusk125 changed the title WIP: CNTRLPLANE-3: Update to k8s 1.32 CNTRLPLANE-3: Update to k8s 1.32 Jan 25, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2025

@dusk125: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8e1f0b8 into openshift:master Jan 25, 2025
3 checks passed
@dusk125 dusk125 deleted the k8s-1.32 branch January 26, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants