WIP: CCO-579: new ccoctl azure flag to enable selection of cloud environment

[jstuever]

Add a new --cloud flag to the ccoctl azure subcommand to enable selection of the cloud environment. The options are AzureChina, AzureGovernment, and AzurePublic. If left empty, the default will be selected from azidenity.

[openshift-ci-robot]

@jstuever: This pull request references CCO-579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Add a new --cloud flag to the ccoctl azure subcommand to enable selection of the cloud environment. The options are AzureChina, AzureGovernment, and AzurePublic. If left empty, the default will be selected from azidenity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 46.69%. Comparing base (c24c925) to head (3373f98).
Report is 30 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/cmd/provisioning/azure/create_all.go	0.00%	13 Missing ⚠️
...md/provisioning/azure/create_managed_identities.go	0.00%	13 Missing ⚠️
pkg/cmd/provisioning/azure/create_oidc_issuer.go	0.00%	13 Missing ⚠️
pkg/cmd/provisioning/azure/delete.go	0.00%	13 Missing ⚠️
pkg/cmd/provisioning/azure/azure.go	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   46.91%   46.69%   -0.23%     
==========================================
  Files         102      102              
  Lines       12158    12216      +58     
==========================================
  Hits         5704     5704              
- Misses       5821     5879      +58     
  Partials      633      633              

Files with missing lines	Coverage Δ
pkg/cmd/provisioning/azure/azure.go	0.00% <0.00%> (ø)
pkg/cmd/provisioning/azure/create_all.go	0.00% <0.00%> (ø)
...md/provisioning/azure/create_managed_identities.go	56.28% <0.00%> (-1.43%)	⬇️
pkg/cmd/provisioning/azure/create_oidc_issuer.go	51.62% <0.00%> (-1.74%)	⬇️
pkg/cmd/provisioning/azure/delete.go	0.00% <0.00%> (ø)

[jstuever]

/test ci/prow/security

[openshift-ci]

@jstuever: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test coverage
• /test e2e-aws-ovn
• /test e2e-azure-manual-oidc
• /test e2e-hypershift
• /test e2e-upgrade
• /test images
• /test okd-scos-images
• /test security
• /test unit
• /test verify
• /test verify-deps

The following commands are available to trigger optional jobs:

• /test e2e-aws-manual-oidc
• /test e2e-aws-qe
• /test e2e-azure
• /test e2e-azure-upgrade
• /test e2e-gcp
• /test e2e-gcp-manual-oidc
• /test e2e-openstack
• /test e2e-openstack-parallel

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-cloud-credential-operator-master-coverage
• pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn
• pull-ci-openshift-cloud-credential-operator-master-e2e-aws-qe
• pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc
• pull-ci-openshift-cloud-credential-operator-master-e2e-hypershift
• pull-ci-openshift-cloud-credential-operator-master-e2e-upgrade
• pull-ci-openshift-cloud-credential-operator-master-images
• pull-ci-openshift-cloud-credential-operator-master-okd-scos-images
• pull-ci-openshift-cloud-credential-operator-master-security
• pull-ci-openshift-cloud-credential-operator-master-unit
• pull-ci-openshift-cloud-credential-operator-master-verify
• pull-ci-openshift-cloud-credential-operator-master-verify-deps

In response to this:

/test ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jstuever]

/test e2e-azure-manual-oidc

[jstuever]

/retest

[jstuever]

/retest

[jstuever]

/retest

[openshift-ci]

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jstuever]

/assign @jianping-shu
Is this something you can test?