Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-571: Add GCP pod identity webhook #758

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jstuever
Copy link
Contributor

This change adds the GCP Workload Identity Webhook when the cluster platform is GCP. The cloud-credential-operator ensures the deployment, pods, and mutating webhook exists.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2024

@jstuever: This pull request references CCO-571 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This change adds the GCP Workload Identity Webhook when the cluster platform is GCP. The cloud-credential-operator ensures the deployment, pods, and mutating webhook exists.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 15, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 48.52%. Comparing base (d668c18) to head (e84e263).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/assets/v410_00_assets/bindata.go 0.00% 18 Missing ⚠️
pkg/operator/podidentity/gcppodidentitywebhook.go 0.00% 10 Missing ⚠️
...rator/podidentity/podidentitywebhook_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   47.24%   48.52%   +1.28%     
==========================================
  Files          96       97       +1     
  Lines       11725    12273     +548     
==========================================
+ Hits         5539     5956     +417     
- Misses       5573     5689     +116     
- Partials      613      628      +15     
Files with missing lines Coverage Δ
...rator/podidentity/podidentitywebhook_controller.go 27.27% <0.00%> (-0.32%) ⬇️
pkg/operator/podidentity/gcppodidentitywebhook.go 0.00% <0.00%> (ø)
pkg/assets/v410_00_assets/bindata.go 42.71% <0.00%> (-4.25%) ⬇️

... and 3 files with indirect coverage changes

This change adds the GCP Workload Identity Webhook when the cluster
platform is GCP. The cloud-credential-operator ensures the deployment,
pods, and mutating webhook exists.
@jstuever
Copy link
Contributor Author

/hold for gcp webhook image to land in release payloads

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@jstuever
Copy link
Contributor Author

/hold cancel
/assign @dlom

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@dlom
Copy link
Contributor

dlom commented Oct 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2a838af into openshift:master Oct 21, 2024
11 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator
This PR has been included in build ose-cloud-credential-operator-container-v4.18.0-202410220012.p0.g2a838af.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants