Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed #117

Closed
wants to merge 1 commit into from
Closed

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed #117

wants to merge 1 commit into from

Conversation

JoelSpeed
Copy link

@JoelSpeed JoelSpeed commented Sep 28, 2020 •
edited
Loading

Revendor to include the bug fix from openshift/machine-api-operator#696

@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Bugzilla bug 1875598, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 28, 2020
@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Bugzilla bug 1875598, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelgugino
michaelgugino approved these changes Sep 28, 2020
View reviewed changes
Copy link

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoelSpeed, michaelgugino
To complete the pull request process, please assign hardys
You can assign the PR to them by writing /assign @hardys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 2, 2020
Merged
@JoelSpeed
Copy link
Author

The contents of this PR are included in #118

I'd prefer to get that one merged to avoid conflicts, so closing this one

@JoelSpeed JoelSpeed closed this Oct 2, 2020
@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Bugzilla bug 1875598. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed JoelSpeed deleted the mao-update-b7d860f8 branch October 2, 2020 12:40
honza pushed a commit to honza/cluster-api-provider-baremetal that referenced this pull request Feb 7, 2022
@metal3-io-bot
Merge pull request openshift#117 from Nordix/v1alpha2
0af28cc 
Fix broken deployment example and update kustomize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino michaelgugino approved these changes

@dhellmann dhellmann Awaiting requested review from dhellmann

@russellb russellb Awaiting requested review from russellb

Assignees

@michaelgugino michaelgugino

Labels
bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoelSpeed @openshift-ci-robot @michaelgugino