-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-37967: rebase CAPO for 4.16 #319
OCPBUGS-37967: rebase CAPO for 4.16 #319
Conversation
…ot/cherry-pick-2074-to-release-0.10 [release-0.10] 🐛 Fix loadbalancer timeout panic
Don't make `remoteManagedGroups` required, since a user can use `remoteIPPrefix` instead or even no remote parameter at all. It's fine because Neutron will set it to an fully-open CIDR if no remote field is provided.
Going forward I won't be able to contribute time to both CPO and CAPO, so this commit drops me from CAPO reviewers list.
…ot/cherry-pick-2082-to-release-0.10 [release-0.10] 🌱 Drop dulek from reviewers
…ot/cherry-pick-2077-to-release-0.10 [release-0.10] 🐛 allNodesSecurityGroupRules: relax remote fields
These errors were ignored up to now, which could lead controller to attempt to recreate an existing instance under rare circumstances.
…ot/cherry-pick-2086-to-release-0.10 [release-0.10] 🐛 Handle errors returned by GetInstanceStatusByName in machine controller
…ot/cherry-pick-2115-to-release-0.10 [release-0.10] 🌱Add EmilienM as a maintainer
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mandre can you please put the labels? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label backport-risk-assessed
/label cherry-pick-approved |
We were not setting IdentityRef.Kind when down-converting an object with no previous version annotation, which results in a validation error.
/retitle NO-JIRA: Merge https://github.com/kubernetes-sigs/cluster-api-provider-openstack:release-0.10 into release-4.16 |
/retitle NO-JIRA: rebase on release-4.16 |
@shiftstack-merge-bot[bot]: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🐛 Fix down-conversion of IdentityRef
f482113
to
f2e71ef
Compare
/lgtm |
@shiftstack-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retitle OCPBUGS-37967: rebase CAPO for 4.16 |
@shiftstack-merge-bot[bot]: This pull request references Jira Issue OCPBUGS-37967, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@EmilienM: This pull request references Jira Issue OCPBUGS-37967, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@EmilienM: This pull request references Jira Issue OCPBUGS-37967, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@EmilienM: This pull request references Jira Issue OCPBUGS-37967, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
86a58d8
into
openshift:release-4.16
@shiftstack-merge-bot[bot]: Jira Issue OCPBUGS-37967: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-37967 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: openstack-cluster-api-controllers |
Fix included in accepted release 4.16.0-0.nightly-2024-08-06-073514 |
No description provided.