UPSTREAM: <carry>: openshift: Remove cluster from machine.openshift.io #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
size/XL
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
Acceptable to switch to the upstream group for the cluster given we don't use it. Seamless change. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-merge-robot
merged commit 0b649f4
into
openshift:openshift-4.0-cluster-api-0.0.0-alpha.4
This was referenced Apr 30, 2019
enxebre
added a commit
to enxebre/cluster-api-provider-libvirt-1
that referenced
this pull request
May 3, 2019
enxebre
added a commit
to enxebre/cluster-api-provider-libvirt-1
that referenced
this pull request
May 3, 2019
openshift/cluster-api#35 dropped the cluster object from machine.openshift.io as the cluster object is still required programatically via actuator interface this uses the one under cluster.k8s.io
enxebre
added a commit
to enxebre/cluster-api-provider-libvirt-1
that referenced
this pull request
May 3, 2019
openshift/cluster-api#35 dropped the cluster object from machine.openshift.io as the cluster object is still required programatically via actuator interface this uses the one under cluster.k8s.io
enxebre
added a commit
to enxebre/cluster-api-provider-libvirt-1
that referenced
this pull request
May 3, 2019
openshift/cluster-api#35 dropped the cluster object from machine.openshift.io as the cluster object is still required programatically via actuator interface this uses the one under cluster.k8s.io
enxebre
added a commit
to enxebre/cluster-api-provider-libvirt-1
that referenced
this pull request
May 3, 2019
openshift/cluster-api#35 dropped the cluster object from machine.openshift.io as the cluster object is still required programatically via actuator interface this uses the one under cluster.k8s.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we mirror the upstream even we don't leverage it we initially put a cluster struct under
machine.openshit.ioThis removes this object from our user facing API completely, which means actuators would need to receive the one in cluster.k8s.io in the interface openshift/cluster-api-provider-aws@c697afa#diff-acdcd15b24a848e93a682408b101755fL107