Copy static pod logs to systemd via --send-static-pod-logs-to-systemd #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
sttts
force-pushed
the
sttts-copy-static-pod-log-to-systemd
branch
from
6b110cf
to
1cc910c
Compare
|
@smarterclayton @wking which do you prefer: sending static pods logs to systemd with |
sttts
force-pushed
the
sttts-copy-static-pod-log-to-systemd
branch
from
1cc910c
to
abcf9b1
Compare
mfojtik
reviewed
Jan 25, 2019
| if len(name) == 0 { | ||
| continue | ||
| } | ||
| podName, _, _ := unstructured.NestedString(container, "labels", "io.kubernetes.pod.name") |
There was a problem hiding this comment.
no, this can be missing (for non-pod containers). Emptyness check is what we want.
sttts
force-pushed
the
sttts-copy-static-pod-log-to-systemd
branch
5 times, most recently
from
4f9859f
to
5d6231f
Compare
|
/retest |
sttts
force-pushed
the
sttts-copy-static-pod-log-to-systemd
branch
from
5d6231f
to
ab5e0c1
Compare
|
/retest |
|
I haven't read the diff here, but it's green (if that's what you were waiting for), and I want the functionality it's advertising ;). |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Feb 5, 2019
Through da6d45b (Merge pull request openshift#890 from staebler/asset_loading_tests, 2019-02-04). Background for the networking.type validation entry is in this thread [1]. Forwarding static-pod longs to systemd is still in flight with [2]. [1]: openshift#1013 (comment) [2]: openshift/cluster-bootstrap#11
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Feb 5, 2019
Through da6d45b (Merge pull request openshift#890 from staebler/asset_loading_tests, 2019-02-04). Background for the networking.type validation entry is in this thread [1]. The OpenStack HAProxy entry has wording based on [2] and Russell's out-of-band suggestions. Forwarding static-pod longs to systemd is still in flight with [3]. [1]: openshift#1013 (comment) [2]: https://github.com/openshift/installer/pull/1185/files#r253714521 [3]: openshift/cluster-bootstrap#11
openshift-ci-robot
added
the
needs-rebase
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Feb 5, 2019
Through da6d45b (Merge pull request openshift#890 from staebler/asset_loading_tests, 2019-02-04). Background for the networking.type validation entry is in this thread [1]. The OpenStack HAProxy entry has wording based on [2] and Russell's out-of-band suggestions. Forwarding static-pod longs to systemd is still in flight with [3]. [1]: openshift#1013 (comment) [2]: https://github.com/openshift/installer/pull/1185/files#r253714521 [3]: openshift/cluster-bootstrap#11
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Feb 5, 2019
Through da6d45b (Merge pull request openshift#890 from staebler/asset_loading_tests, 2019-02-04). Background for the networking.type validation entry is in this thread [1]. The OpenStack HAProxy entry has wording based on [2] and Russell's out-of-band suggestions. Forwarding static-pod longs to systemd is still in flight with [3]. [1]: openshift#1013 (comment) [2]: https://github.com/openshift/installer/pull/1185/files#r253714521 [3]: openshift/cluster-bootstrap#11
|
Also in this space: containers/podman#2265. Presumably any changes to |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to get static pod logs when the installer fails for some reason. We already scrape bootkube, cri-o and kubelet. This change will "copy" the cri-o container logs to systemd unit via
systemd-run --unit <pod-name> crictl logs <container-id>. After that we can scrape it from the CI job through journald.Follow-up of openshift/release#2633.