[release-4.14] OCPBUGS-19849: Set dual-stack IPFamilyPriority for vSphere #283

openshift-cherrypick-robot · 2023-09-27T13:34:18Z

This is an automated cherry-pick of #279

/assign mkowalski

We have discovered that in dual-stack setups NodeAddresses field of the instance metadata contains only IPv4 addresses for VMs that do have both IPv4 and IPv6 addresses assigned (and detected by the VM agent). It has been traced back to the function responsible for populating this metadata field. We found out that for our configuration we always filter only IPv4 addresses even if running in dual-stack. Reason for that is that `IPFamilyPriority` has a value of `ipv4` even when running in a dual-stack setup. This causes an issue because this instance metadata is cross-checked with addresses provided by the kubelet as part of the `alpha.kubernetes.io/provided-node-ip` annotation. Without correct value of `IPFamilyPriority` we are thus removing all the IPv6 addresses. This PR takes advantage of the Service Networks configured by the user in install-config and the fact that we only allow 2 networks to be configured if the setup is dual-stack. Fixes: OCPBUGS-18641

openshift-ci-robot · 2023-09-27T13:34:31Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-18641 has been cloned as Jira Issue OCPBUGS-19849. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-19849: Set dual-stack IPFamilyPriority for vSphere

In response to this:

This is an automated cherry-pick of #279

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-27T13:35:12Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19849, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18641 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-18641 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #279

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkowalski · 2023-09-27T13:35:44Z

/lgtm

Clean cherry-pick

rbbratta · 2023-09-27T16:27:41Z

vsphere,dualstack clusterbot success https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-vsphere-modern/1707054954306342912

rbbratta · 2023-09-27T16:40:06Z

    nodes:
      excludeInternalNetworkSubnetCidr: 192.168.94.3/32,fd65:a1a8:60ad:271c::200/128,192.168.94.4/32,fd65:a1a8:60ad:271c::201/128,fd69::2/128
      excludeExternalNetworkSubnetCidr: 192.168.94.3/32,fd65:a1a8:60ad:271c::200/128,192.168.94.4/32,fd65:a1a8:60ad:271c::201/128,fd69::2/128

rbbratta · 2023-09-27T16:48:28Z

2023-09-27T16:24:32.681765497Z I0927 16:24:32.681759       1 instances.go:77] instances.NodeAddressesByProviderID() FOUND with 42052dd7-63c7-963d-63c7-
2023-09-27T16:24:32.689820931Z I0927 16:24:32.689791       1 search.go:69] WhichVCandDCByNodeID by UUID
2023-09-27T16:24:32.689870219Z I0927 16:24:32.689863       1 search.go:76] WhichVCandDCByNodeID nodeID: 4205ae4c-6509-14a9-53ee-
2023-09-27T16:24:32.711986931Z I0927 16:24:32.711844       1 search.go:208] Found node 4205ae4c-6509-14a9-53ee-d15ab4eb42ce as vm=VirtualMachine:vm-830634 in
2023-09-27T16:24:32.711986931Z I0927 16:24:32.711875       1 search.go:210] Hostname: ci-ln-i8d0nsb-c1627-khn2n-worker-0-5k2sx, UUID: 4205ae4c-6509-14a9-53ee-
2023-09-27T16:24:32.711986931Z I0927 16:24:32.711900       1 nodemanager.go:159] Discovered VM using normal UUID format
2023-09-27T16:24:32.719048855Z I0927 16:24:32.718999       1 nodemanager.go:268] Adding Hostname: ci-ln-i8d0nsb-c1627-khn2n-worker-0-5k2sx
2023-09-27T16:24:32.719102588Z I0927 16:24:32.719048       1 nodemanager.go:438] Adding Internal IP: 192.168.94.56
2023-09-27T16:24:32.719102588Z I0927 16:24:32.719054       1 nodemanager.go:443] Adding External IP: 192.168.94.56
2023-09-27T16:24:32.719102588Z I0927 16:24:32.719069       1 nodemanager.go:438] Adding Internal IP: fd65:a1a8:60ad:271c::b3
2023-09-27T16:24:32.719102588Z I0927 16:24:32.719073       1 nodemanager.go:443] Adding External IP: fd65:a1a8:60ad:271c::b3
2023-09-27T16:24:32.719102588Z I0927 16:24:32.719083       1 nodemanager.go:349] Found node 4205ae4c-6509-14a9-53ee-d15ab4eb42ce as vm=VirtualMachine:vm-830634 in
2023-09-27T16:24:32.719112846Z I0927 16:24:32.719100       1 nodemanager.go:351] Hostname: ci-ln-i8d0nsb-c1627-khn2n-worker-0-5k2sx UUID: 4205ae4c-6509-14a9-53ee-
2023-09-27T16:24:32.719112846Z I0927 16:24:32.719110       1 instances.go:77] instances.NodeAddressesByProviderID() FOUND with 4205ae4c-6509-14a9-53ee-
2023-09-27T16:24:32.728399386Z I0927 16:24:32.728348       1 node_controller.go:263] Update 6 nodes status took 283.88867ms.

rbbratta · 2023-09-27T16:48:38Z

/label qe-approved

JoelSpeed · 2023-09-28T10:34:01Z

/approve
/lgtm

JoelSpeed · 2023-09-28T10:35:12Z

/label backport-risk-assessed

openshift-ci · 2023-09-28T10:37:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mkowalski · 2023-09-28T11:46:50Z

/label cherry-pick-approved

openshift-ci · 2023-09-28T11:46:52Z

@mkowalski: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rbbratta · 2023-09-28T11:47:47Z

/label cherry-pick-approved

openshift-ci · 2023-09-28T11:47:49Z

@rbbratta: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sunzhaohua2 · 2023-09-28T14:45:41Z

/label cherry-pick-approved

openshift-ci-robot · 2023-09-28T15:01:32Z

/retest-required

Remaining retests: 0 against base HEAD 0ed1f76 and 2 for PR HEAD d925444 in total

openshift-ci · 2023-09-28T16:53:02Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn	`d925444`	link	false	`/test e2e-vsphere-ovn`
ci/prow/e2e-gcp-ovn-ccm	`d925444`	link	false	`/test e2e-gcp-ovn-ccm`
ci/prow/e2e-azure-ovn-upgrade	`d925444`	link	false	`/test e2e-azure-ovn-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mkowalski · 2023-10-02T08:44:43Z

vSphere test waiting for openshift/kubernetes#1730 to merge

mkowalski · 2023-10-02T08:44:52Z

/hold

openshift-ci-robot · 2023-10-02T08:45:13Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19849, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18641 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-18641 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @miyadav

In response to this:

This is an automated cherry-pick of #279

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miyadav · 2023-10-03T04:52:04Z

/label cherry-pick-approved , based on test

mkowalski · 2023-10-03T08:04:34Z

Still fighting with the vSphere storage issues via openshift/kubernetes#1730. They are hard-blocking the tests to pass even though the underlying issue (fixed upstream via kubernetes/kubernetes#120961) is not related to our change

mkowalski · 2023-10-03T08:26:41Z

/unhold

Based on Milind's successful test and the fact that periodics in o/release explicitly ignore in-tree storage tests

TEST_SKIPS: 'In-tree Volumes \[Driver: vsphere\] \[Testpattern: Inline-volume\|
        In-tree Volumes \[Driver: vsphere\] \[Testpattern: Pre-provisioned PV'

I am okay with unholding in letting this merge. We will see very quickly (next nightly) if that broke anything, but I strongly believe that it will not happen

openshift-ci-robot · 2023-10-03T08:26:46Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19849, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18641 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-18641 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @miyadav

In response to this:

This is an automated cherry-pick of #279

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkowalski · 2023-10-03T08:31:24Z

/test e2e-alibaba-ovn

Blind retest, I don't need alibaba to pass in vsphere

JoelSpeed · 2023-10-03T08:36:44Z

/override ci/prow/e2e-alibaba-ovn

This was made to be required by accident, it shouldn't be needed

openshift-ci · 2023-10-03T08:37:01Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-alibaba-ovn

In response to this:

/override ci/prow/e2e-alibaba-ovn

This was made to be required by accident, it shouldn't be needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-03T08:40:59Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19849: All pull requests linked via external trackers have merged:

openshift/cluster-cloud-controller-manager-operator#283

Jira Issue OCPBUGS-19849 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #279

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-03T08:41:52Z

/retest-required

Remaining retests: 0 against base HEAD 59465af and 1 for PR HEAD d925444 in total

openshift-cherrypick-robot assigned mkowalski Sep 27, 2023

openshift-cherrypick-robot mentioned this pull request Sep 27, 2023

OCPBUGS-18641: Set dual-stack IPFamilyPriority for vSphere #279

Merged

openshift-ci bot changed the title ~~[release-4.14] OCPBUGS-18641: Set dual-stack IPFamilyPriority for vSphere~~ [release-4.14] OCPBUGS-19849: Set dual-stack IPFamilyPriority for vSphere Sep 27, 2023

openshift-ci bot requested a review from sunzhaohua2 September 27, 2023 13:35

openshift-ci bot requested review from JoelSpeed and elmiko September 27, 2023 13:37

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 27, 2023

openshift-ci bot assigned JoelSpeed Sep 28, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 28, 2023

openshift-ci bot assigned huali9, jhou1, miyadav and sunzhaohua2 Sep 28, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 28, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2023

openshift-ci bot requested a review from miyadav October 2, 2023 08:45

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023

openshift-ci bot merged commit 59465af into openshift:release-4.14 Oct 3, 2023

[release-4.14] OCPBUGS-19849: Set dual-stack IPFamilyPriority for vSphere #283

[release-4.14] OCPBUGS-19849: Set dual-stack IPFamilyPriority for vSphere #283

Uh oh!

Conversation

openshift-cherrypick-robot commented Sep 27, 2023

Uh oh!

openshift-ci-robot commented Sep 27, 2023

Uh oh!

openshift-ci-robot commented Sep 27, 2023

Uh oh!

mkowalski commented Sep 27, 2023

Uh oh!

rbbratta commented Sep 27, 2023

Uh oh!

rbbratta commented Sep 27, 2023

Uh oh!

rbbratta commented Sep 27, 2023

Uh oh!

rbbratta commented Sep 27, 2023

Uh oh!

JoelSpeed commented Sep 28, 2023

Uh oh!

JoelSpeed commented Sep 28, 2023

Uh oh!

openshift-ci bot commented Sep 28, 2023

Uh oh!

mkowalski commented Sep 28, 2023

Uh oh!

openshift-ci bot commented Sep 28, 2023

Uh oh!

rbbratta commented Sep 28, 2023

Uh oh!

openshift-ci bot commented Sep 28, 2023

Uh oh!

sunzhaohua2 commented Sep 28, 2023

Uh oh!

openshift-ci-robot commented Sep 28, 2023

Uh oh!

openshift-ci bot commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkowalski commented Oct 2, 2023

Uh oh!

mkowalski commented Oct 2, 2023

Uh oh!

openshift-ci-robot commented Oct 2, 2023

Uh oh!

miyadav commented Oct 3, 2023

Uh oh!

mkowalski commented Oct 3, 2023

Uh oh!

mkowalski commented Oct 3, 2023

Uh oh!

openshift-ci-robot commented Oct 3, 2023

Uh oh!

mkowalski commented Oct 3, 2023

Uh oh!

JoelSpeed commented Oct 3, 2023

Uh oh!

openshift-ci bot commented Oct 3, 2023

Uh oh!

openshift-ci-robot commented Oct 3, 2023

Uh oh!

openshift-ci-robot commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

openshift-ci bot commented Sep 28, 2023 •

edited

Loading