Skip to content

OCPVE-660: add CloudController capability annotation #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

OCPVE-660: add CloudController capability annotation #284

merged 1 commit into from
Mar 6, 2024

Conversation

@qJkee
Copy link
Contributor

@qJkee qJkee commented Oct 2, 2023

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023 •
edited by openshift-ci bot
Loading

@qJkee: This pull request references OCPVE-660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2023
@openshift-ci openshift-ci bot requested review from RadekManak and damdo October 2, 2023 15:34
@qJkee qJkee changed the title OCPVE-660: add CloudController capability annotation [WIP] OCPVE-660: add CloudController capability annotation Oct 9, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023 •
edited by openshift-ci bot
Loading

@qJkee: This pull request references OCPVE-660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

openshift-bot commented Feb 15, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2024
@qJkee qJkee changed the title [WIP] OCPVE-660: add CloudController capability annotation OCPVE-660: add CloudController capability annotation Feb 28, 2024
@qJkee
Copy link
Contributor Author

qJkee commented Feb 28, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 28, 2024
elmiko
elmiko reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks ok to me
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@elmiko
Copy link
Contributor

elmiko commented Feb 28, 2024

just noticed the images job, want to make sure that is passing

/lgtm cancel
/test images

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
JoelSpeed
JoelSpeed reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me the effect of the + syntax in capabilities? IIUC there is no or syntax right?

@qJkee
Copy link
Contributor Author

qJkee commented Feb 29, 2024

Can you remind me the effect of the + syntax in capabilities? IIUC there is no or syntax right?

@JoelSpeed
https://github.com/openshift/enhancements/blob/master/enhancements/installer/component-selection.md#manifest-annotations

@qJkee
Copy link
Contributor Author

qJkee commented Mar 2, 2024

/retest

1 similar comment
@qJkee
Copy link
Contributor Author

qJkee commented Mar 4, 2024

/retest

@qJkee
Copy link
Contributor Author

qJkee commented Mar 5, 2024

failures caused by ci issues
/retest

@qJkee
Copy link
Contributor Author

qJkee commented Mar 6, 2024

/retest

elmiko
elmiko reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2024

/retest-required

Remaining retests: 0 against base HEAD 2d2016b and 2 for PR HEAD 5168fc9 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview 8eefdd3 link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-gcp-ovn-ccm 8eefdd3 link false /test e2e-gcp-ovn-ccm
ci/prow/e2e-alibaba-ovn 8eefdd3 link false /test e2e-alibaba-ovn
ci/prow/e2e-azure-ovn-upgrade 5168fc9 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-ibmcloud-ovn 5168fc9 link false /test e2e-ibmcloud-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0de1568 into openshift:master Mar 6, 2024
@openshift-bot
Copy link

openshift-bot commented Mar 6, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202403061739.p0.g0de1568.assembly.stream.el9 for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@damdo damdo Awaiting requested review from damdo

@RadekManak RadekManak Awaiting requested review from RadekManak

+1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qJkee @openshift-ci-robot @openshift-bot @elmiko @JoelSpeed @openshift-merge-robot