-
Notifications
You must be signed in to change notification settings - Fork 73
OCPBUGS-29220: Set AZURE_FEDERATED_TOKEN_FILE on CCM container #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29220: Set AZURE_FEDERATED_TOKEN_FILE on CCM container #332
Conversation
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-29220, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test ? |
|
@JoelSpeed: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-azure-manual-oidc |
|
/jira refresh |
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-29220, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-azure-manual-oidc |
4 similar comments
|
/test e2e-azure-manual-oidc |
|
/test e2e-azure-manual-oidc |
|
/test e2e-azure-manual-oidc |
|
/test e2e-azure-manual-oidc |
|
/retest-required Manual OIDC job has successfully installed a cluster, so the patch is working |
elmiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@JoelSpeed: Jira Issue OCPBUGS-29220: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29220 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202402132010.p0.gd3b92b9.assembly.stream.el9 for distgit ose-cluster-cloud-controller-manager-operator. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806 |
The Auth provider in the CCM has changed in 4.16 and is now relying on a different field within the Azure config,
AADClientCertPath. It is not clear to me if this is intentional or not.The field in the config can be overridden by setting this environment variable. It appears that this will be an easier long term fix while we ascertain if the upstream change should be reverted.