Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

The Auth provider in the CCM has changed in 4.16 and is now relying on a different field within the Azure config, AADClientCertPath. It is not clear to me if this is intentional or not.

The field in the config can be overridden by setting this environment variable. It appears that this will be an easier long term fix while we ascertain if the upstream change should be reverted.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 12, 2024
@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Jira Issue OCPBUGS-29220, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The Auth provider in the CCM has changed in 4.16 and is now relying on a different field within the Azure config, AADClientCertPath. It is not clear to me if this is intentional or not.

The field in the config can be overridden by setting this environment variable. It appears that this will be an easier long term fix while we ascertain if the upstream change should be reverted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@JoelSpeed: The following commands are available to trigger required jobs:

  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test fmt
  • /test images
  • /test lint
  • /test unit
  • /test vendor
  • /test vet

The following commands are available to trigger optional jobs:

  • /test e2e-azure-manual-oidc
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upgrade
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-ibmcloud-ovn
  • /test e2e-nutanix-ovn
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-azure-ovn
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-azure-ovn-upgrade
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-openstack-ovn
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-vsphere-ovn
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-fmt
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-images
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-lint
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-unit
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-vendor
  • pull-ci-openshift-cluster-cloud-controller-manager-operator-master-vet

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor Author

/test e2e-azure-manual-oidc

@JoelSpeed
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 12, 2024
@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Jira Issue OCPBUGS-29220, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor Author

/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-azure-ovn-upgrade

4 similar comments
@JoelSpeed
Copy link
Contributor Author

/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-azure-ovn-upgrade

@JoelSpeed
Copy link
Contributor Author

/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-azure-ovn-upgrade

@JoelSpeed
Copy link
Contributor Author

/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-azure-ovn-upgrade

@JoelSpeed
Copy link
Contributor Author

/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-azure-ovn-upgrade

@JoelSpeed
Copy link
Contributor Author

/retest-required

Manual OIDC job has successfully installed a cluster, so the patch is working

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade 21c9012 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn 21c9012 link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn 21c9012 link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn 21c9012 link false /test e2e-gcp-ovn
ci/prow/e2e-azure-manual-oidc 21c9012 link false /test e2e-azure-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d3b92b9 into openshift:master Feb 13, 2024
@openshift-ci-robot
Copy link

@JoelSpeed: Jira Issue OCPBUGS-29220: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29220 has been moved to the MODIFIED state.

In response to this:

The Auth provider in the CCM has changed in 4.16 and is now relying on a different field within the Azure config, AADClientCertPath. It is not clear to me if this is intentional or not.

The field in the config can be overridden by setting this environment variable. It appears that this will be an easier long term fix while we ascertain if the upstream change should be reverted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202402132010.p0.gd3b92b9.assembly.stream.el9 for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants