Skip to content

Conversation

@MaysaMacedo
Copy link
Contributor

With new events being adding to cloud-provider-openstack it's now required to also allow patching events.

With new events being adding to cloud-provider-openstack
it's now required to also allow patching events.
@MaysaMacedo
Copy link
Contributor Author

/cc @dulek

This is required for kubernetes/cloud-provider-openstack#2557

@openshift-ci openshift-ci bot requested review from dulek, nrb and vincepri March 7, 2024 13:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade a6becb1 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn a6becb1 link false /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dulek
Copy link
Contributor

dulek commented Mar 7, 2024

/approve

@dulek
Copy link
Contributor

dulek commented Mar 7, 2024

Ah, I can't approve here.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@MaysaMacedo
Copy link
Contributor Author

/assign @elmiko

@nrb
Copy link
Contributor

nrb commented Mar 7, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@MaysaMacedo MaysaMacedo changed the title Allow to patch events in OpenStack RBAC Bug OCPBUGS-29605: Allow to patch events in OpenStack RBAC Mar 8, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 8, 2024
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-29605, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

With new events being adding to cloud-provider-openstack it's now required to also allow patching events.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 8, 2024
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-29605, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7c8ece7 into openshift:master Mar 8, 2024
@openshift-ci-robot
Copy link

@MaysaMacedo: Jira Issue OCPBUGS-29605: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29605 has been moved to the MODIFIED state.

In response to this:

With new events being adding to cloud-provider-openstack it's now required to also allow patching events.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo MaysaMacedo deleted the enable-patch-events branch March 8, 2024 14:37
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202403081913.p0.g7c8ece7.assembly.stream.el9 for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

@MaysaMacedo
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@MaysaMacedo: new pull request created: #339

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants