Skip to content

[release-4.15] OCPBUGS-43554: update goimports targets #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-43554: update goimports targets #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
linters:
# https://golangci-lint.run/usage/linters/#enabled-by-default-linters
enable:
# default linters
- errcheck
- gosimple
- govet
- ineffassign
- staticcheck
- unused
# optional linters
- goimports

4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ manifests:
# Run go fmt against code
.PHONY: fmt
fmt:
hack/goimports.sh
go fmt ./...

# Run go vet against code
.PHONY: vet
Expand All @@ -69,7 +69,7 @@ vet:
# Run golangci-lint against code
.PHONY: lint
lint:
( GOLANGCI_LINT_CACHE=$(PROJECT_DIR)/.cache $(GOLANGCI_LINT) run --timeout 10m )
( GOLANGCI_LINT_CACHE=$(PROJECT_DIR)/.cache $(GOLANGCI_LINT) run --timeout 10m -v)

# Run go mod
.PHONY: vendor
Expand Down
22 changes: 0 additions & 22 deletions hack/goimports.sh
View file
Open in desktop

This file was deleted.