Skip to content

SPLAT-2297: Added new cmd flag to launch of vSphere CCM #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SPLAT-2297: Added new cmd flag to launch of vSphere CCM #394

wants to merge 2 commits into from

Conversation

@vr4manta
Copy link

@vr4manta vr4manta commented Jul 2, 2025 •
edited
Loading

SPLAT-2297

Changes

  • Added new section into deployment of vSphere CCM to provide additional node labels to apply when registering vSphere nodes.

Dependencies

Notes

The vSphere CCM changes will need to be done upstream. This PR should be addressing adding the new cmd flag to enable it. We'll need to use a featureGate to wrap setting the value in the deployment so that we do not impact vSphere clusters that are not using the new hybrid environment feature.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

SPLAT-2297

Changes

  • Added new section into deployment of vSphere CCM to provide additional node labels to apply when registering vSphere nodes.

Notes

The vSphere CCM changes will need to be done upstream. This PR should be addressing adding the new cmd flag to enable it. We'll need to use a featureGate to wrap setting the value in the deployment so that we do not impact vSphere clusters that are not using the new hybrid environment feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

SPLAT-2297

Changes

  • Added new section into deployment of vSphere CCM to provide additional node labels to apply when registering vSphere nodes.

Notes

The vSphere CCM changes will need to be done upstream. This PR should be addressing adding the new cmd flag to enable it. We'll need to use a featureGate to wrap setting the value in the deployment so that we do not impact vSphere clusters that are not using the new hybrid environment feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign theobarberbany for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta
Copy link
Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2297

Changes

  • Added new section into deployment of vSphere CCM to provide additional node labels to apply when registering vSphere nodes.

Dependencies

Notes

The vSphere CCM changes will need to be done upstream. This PR should be addressing adding the new cmd flag to enable it. We'll need to use a featureGate to wrap setting the value in the deployment so that we do not impact vSphere clusters that are not using the new hybrid environment feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta marked this pull request as ready for review October 17, 2025 17:08
@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

1 similar comment
@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

@vr4manta vr4manta force-pushed the SPLAT-2297 branch 3 times, most recently from 360f768 to 901b40b Compare October 17, 2025 19:42
@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

1 similar comment
@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

1 similar comment
@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

@vr4manta
Copy link
Author

/test e2e-vsphere-ovn

@vr4manta vr4manta changed the title [WIP] SPLAT-2297: Added new cmd flag to launch of vSphere CCM SPLAT-2297: Added new cmd flag to launch of vSphere CCM Oct 22, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2025
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/level0-clusterinfra-azure-ipi-proxy-tests 15129fe link false /test level0-clusterinfra-azure-ipi-proxy-tests
ci/prow/e2e-aws-ovn 15129fe link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 15129fe link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Author

/retest-required

@vr4manta
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-hybrid-env

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-hybrid-env

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebdceb40-b00e-11f0-9c18-bac3cea1496d-0

@vr4manta
Copy link
Author

Ran hybrid env periodical and it passed (see above). I also confirmed the new label is on the nodes:

  labels:
    beta.kubernetes.io/arch: amd64
    beta.kubernetes.io/instance-type: vsphere-vm.cpu-4.mem-16gb.os-unknown
    beta.kubernetes.io/os: linux
    kubernetes.io/arch: amd64
    kubernetes.io/hostname: ci-op-v8748xb8-4e359-r75nv-master-0
    kubernetes.io/os: linux
    node-role.kubernetes.io/control-plane: ""
    node-role.kubernetes.io/master: ""
    node.cluster.x-k8s.io/esxi-host: ci-vmware-host-31.ci.ibmc.devcluster.openshift.com
    node.kubernetes.io/instance-type: vsphere-vm.cpu-4.mem-16gb.os-unknown
    node.openshift.io/os_id: rhel
    node.openshift.io/platform-type: vsphere

the node.openshift.io/platform-type: vsphere is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@jcpowermac jcpowermac

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vr4manta @openshift-ci-robot @openshift-bot @jcpowermac @openshift-merge-robot