-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1927942: pkg/etcdenvvar: enable SO_REUSEADDR #553
Bug 1927942: pkg/etcdenvvar: enable SO_REUSEADDR #553
Conversation
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion: This pull request references Bugzilla bug 1927942, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold depends on openshift/etcd#70 |
@hexfusion: This pull request references Bugzilla bug 1927942, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
@hexfusion: This pull request references Bugzilla bug 1927942, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hexfusion: This pull request references Bugzilla bug 1927942, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since this is just adding an environment variable, should not really be dependent on the changes to openshift/etcd. Leaving the hold /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, retroflexer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/test e2e-agnostic |
/retest |
1 similar comment
/retest |
@hexfusion: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold cancel These needs soak and if we have issues this PR is the toggle. |
@hexfusion: All pull requests linked via external trackers have merged: Bugzilla bug 1927942 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds support for setting socket options
SO_REUSEADDR
[1] to etcd listeners viaListenConfig
. What we have found is during etcd process restart there can be a considerable time waiting for the port to release byTIME_WAIT
which for OpenShift is 60 seconds..So we can wait for many seconds even after etcd process is long dead for client and peer ports to become available.
A similar approach has been taken with the addition of these options in the kube-apiserver[2][3]
[1] https://man7.org/linux/man-pages/man7/socket.7.html
[2] kubernetes/kubernetes#93861
[3] openshift/kubernetes#309
depends on openshift/etcd#70