Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-6072: Increase default collector memory limit #2799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cahartma
Copy link
Contributor

Description

We've had a few reports of OOM issues during testing of pre-release 6.0, mainly lokistack and the new otlp output (all log_types). Best solution, we've decided to double the memory limit only, while leaving the other defaults alone. We need more feedback and possibly add otlp to benchmark functional tests.

One other option we can explore before GA is modifying the group_by MaxEvents in the otlp output. (and possibly allowing it to be configurable)

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2024

@cahartma: This pull request references LOG-6072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

We've had a few reports of OOM issues during testing of pre-release 6.0, mainly lokistack and the new otlp output (all log_types). Best solution, we've decided to double the memory limit only, while leaving the other defaults alone. We need more feedback and possibly add otlp to benchmark functional tests.

One other option we can explore before GA is modifying the group_by MaxEvents in the otlp output. (and possibly allowing it to be configurable)

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2024
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Clee2691
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@Clee2691
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants