Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-5706: Align syslog output implementation with spec RFC3164 and RFC5124 for Vector #2953

Open
wants to merge 1 commit into
base: release-5.9
Choose a base branch
from
Open

LOG-5706: Align syslog output implementation with spec RFC3164 and RFC5124 for Vector #2953

wants to merge 1 commit into from

Conversation

vparfonov
Copy link
Contributor

Description

Backport for #2830

/cc @cahartma
/assign @jcantrill

/cherry-pick

Links

@vparfonov
LOG-5706: Align syslog output implementation with spec RFC3164 and RF…
1662e8c 
…C5124 for Vector

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2025
@openshift-ci-robot
Copy link

@vparfonov: This pull request references LOG-5706 which is a valid jira issue.

In response to this:

Description

Backport for #2830

/cc @cahartma
/assign @jcantrill

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vparfonov
Once this PR has been reviewed and has the lgtm label, please assign cahartma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vparfonov
Copy link
Contributor Author

/retest

@vparfonov
Copy link
Contributor Author

/test unit

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jcantrill
jcantrill reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2025
jcantrill
jcantrill reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about this further. I wish I would have considered the larger implications of this change before you did the work as I think its adding in "features" we wish to not backport

internal/generator/vector/helpers/helpers.go
@@ -56,3 +59,49 @@ func ListenOnAllLocalInterfacesAddress() string {
func EscapeDollarSigns(s string) string {
return strings.ReplaceAll(s, "$", "$$")
}

// TransformUserTemplateToVRL converts the user entered template to VRL compatible syntax
// Example: foo-{.log_type||"none"} -> "foo-" + to_string!(.log_type||"none")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that we need to reject these changes for 5.9 and earlier. My brief review of the API is we don't support templating like 6.x and I'm hesitant to add that functionality here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@alanconway alanconway Awaiting requested review from alanconway

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vparfonov @openshift-ci-robot @jcantrill