Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Buffer tuning for https://issues.redhat.com/browse/RFE-6849 #2961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alanconway
Copy link
Contributor

This PR has the proposed API changes needed for https://issues.redhat.com/browse/RFE-6849
The functionality is not implemented.

This PR has the proposed API changes needed for RFE-6849.
The functionality is not implemented.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
@openshift-ci openshift-ci bot requested review from cahartma and jcantrill February 13, 2025 19:59
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

@alanconway: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional-target b7d2645 link true /test functional-target
ci/prow/e2e-target b7d2645 link true /test e2e-target
ci/prow/unit b7d2645 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

api/observability/v1/output_types.go Show resolved Hide resolved
api/observability/v1/output_types.go Show resolved Hide resolved
api/observability/v1/output_types.go Show resolved Hide resolved
api/observability/v1/output_types.go Show resolved Hide resolved
api/observability/v1/output_types.go Show resolved Hide resolved
@alanconway
Copy link
Contributor Author

@jcantrill all good catches, hopefully now all fixed. Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants