-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Open source #1
Conversation
@brancz: GitHub didn't allow me to request PR reviews from the following users: fabxc, ant31. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!
CONTRIBUTING.md
Outdated
@@ -0,0 +1,77 @@ | |||
# How to Contribute | |||
|
|||
CoreOS projects are [Apache 2.0 licensed](LICENSE) and accept contributions via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/CoreOS/Red Hat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change it to "Red Hat projects are" it becomes a bit wrong, because not all our projects use the Apache license.
I would suggest changing the words "CoreOS projects" to "The cluster-monitoring-operator".
if folks can do a quick find/replace on CoreOS -> cluster-monitoring-operator and say we are good, we can get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this :)
🎉 🎉 🎉 merging 🎉 🎉 🎉 |
Fix formatting
This PR open sources the work we have been doing adapting the monitoring stack previously developed for CoreOS Tectonic for OpenShift.
@derekwaynecarr Let me know if you want to setup CI and hooks etc before or after we merge this.
/cc @mxinden @ironcladlou @elad661 @ant31 @fabxc