Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Open source #1

Merged
merged 1 commit into from
Apr 13, 2018
Merged

*: Open source #1

merged 1 commit into from
Apr 13, 2018

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Apr 12, 2018

This PR open sources the work we have been doing adapting the monitoring stack previously developed for CoreOS Tectonic for OpenShift.

@derekwaynecarr Let me know if you want to setup CI and hooks etc before or after we merge this.

/cc @mxinden @ironcladlou @elad661 @ant31 @fabxc

@openshift-ci-robot
Copy link
Contributor

@brancz: GitHub didn't allow me to request PR reviews from the following users: fabxc, ant31.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This PR open sources the work we have been doing adapting the monitoring stack previously developed for CoreOS Tectonic for OpenShift.

@derekwaynecarr Let me know if you want to setup CI and hooks etc before or after we merge this.

/cc @mxinden @ironcladlou @elad661 @ant31 @fabxc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 12, 2018
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

CONTRIBUTING.md Outdated
@@ -0,0 +1,77 @@
# How to Contribute

CoreOS projects are [Apache 2.0 licensed](LICENSE) and accept contributions via
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/CoreOS/Red Hat

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change it to "Red Hat projects are" it becomes a bit wrong, because not all our projects use the Apache license.

I would suggest changing the words "CoreOS projects" to "The cluster-monitoring-operator".

@derekwaynecarr
Copy link
Member

if folks can do a quick find/replace on CoreOS -> cluster-monitoring-operator and say we are good, we can get this merged.

Copy link

@elad661 elad661 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this :)

@brancz
Copy link
Contributor Author

brancz commented Apr 13, 2018

🎉 🎉 🎉 merging 🎉 🎉 🎉

@brancz brancz merged commit 7fca7d7 into openshift:master Apr 13, 2018
@brancz brancz deleted the initial-pr branch April 13, 2018 11:12
simonpasquier pushed a commit to simonpasquier/cluster-monitoring-operator that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants