Skip to content

Commit 3584d79

Browse files
Merge pull request #2212 from openshift-cherrypick-robot/cherry-pick-2206-to-release-4.15
[release-4.15] OCPBUGS-27421: Only reconcile on Node updates with Label changes
2 parents 916cbb1 + 057111b commit 3584d79

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

pkg/controller/operconfig/operconfig_controller.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,13 @@ func add(mgr manager.Manager, r *ReconcileOperConfig) error {
183183
CreateFunc: func(_ event.CreateEvent) bool {
184184
return true
185185
},
186-
UpdateFunc: func(_ event.UpdateEvent) bool {
187-
return true
186+
UpdateFunc: func(ev event.UpdateEvent) bool {
187+
// Node conditions change *a lot* and we don't care. We only care
188+
// about updates when the labels change.
189+
return !reflect.DeepEqual(
190+
ev.ObjectOld.GetLabels(),
191+
ev.ObjectNew.GetLabels(),
192+
)
188193
},
189194
DeleteFunc: func(_ event.DeleteEvent) bool {
190195
return true

0 commit comments

Comments
 (0)