Skip to content

[release-4.15] OCPBUGS-27421: Only reconcile on Node updates with Label changes#2212

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-2206-to-release-4.15
Feb 6, 2024
Merged

[release-4.15] OCPBUGS-27421: Only reconcile on Node updates with Label changes#2212
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-2206-to-release-4.15

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 19, 2024

This is an automated cherry-pick of #2206

/assign danwinship

@danwinship
Only reconcile on Node updates with Label changes
057111b 
Reconciling every time any Node.Status.Condition changes means CNO
just ends up constantly reconciling.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 19, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27264 has been cloned as Jira Issue OCPBUGS-27421. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-27421: Only reconcile on Node updates with Label changes

Details

In response to this:

This is an automated cherry-pick of #2206

/assign danwinship

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-27264: Only reconcile on Node updates with Label changes [release-4.15] OCPBUGS-27421: Only reconcile on Node updates with Label changes Jan 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-27421, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27264 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-27264 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2206

/assign danwinship

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danwinship
Copy link
Contributor

danwinship commented Jan 19, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 057111b link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-vsphere-ovn 057111b link false /test e2e-vsphere-ovn
ci/prow/e2e-aws-sdn-upgrade 057111b link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-ovn-hybrid-step-registry 057111b link false /test e2e-ovn-hybrid-step-registry
ci/prow/4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade 057111b link false /test 4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack 057111b link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 057111b link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor

danwinship commented Jan 20, 2024

/retest-required

@trozet
Copy link
Contributor

trozet commented Feb 1, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 1, 2024
@asood-rh
Copy link

asood-rh commented Feb 5, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3584d79 into openshift:release-4.15 Feb 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 6, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27421: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27421 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #2206

/assign danwinship

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 6, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.15.0-202402060138.p0.g3584d79.assembly.stream for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 6, 2024

Fix included in accepted release 4.15.0-0.nightly-2024-02-06-040314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@dcbw dcbw Awaiting requested review from dcbw

@trozet trozet Awaiting requested review from trozet

Assignees

@danwinship danwinship

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@rlobillo rlobillo

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.