Skip to content

Commit

Permalink
Bug 1866200: fix recording rules group name
Browse files Browse the repository at this point in the history
The `general.rules` group name conflicts with others, causing them to be merged with other rules in OpenShift console via Thanos Querier.

This fixes it.
  • Loading branch information
s-urbaniak committed Aug 11, 2020
1 parent c2e5f8a commit f8fb356
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion bindata/network/kuryr/alert-rules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
namespace: openshift-kuryr
spec:
groups:
- name: general.rules
- name: cluster-network-operator-kuryr.rules
rules:
- alert: NoRunningKuryrKubernetes
annotations:
Expand Down
2 changes: 1 addition & 1 deletion bindata/network/openshift-sdn/alert-rules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
namespace: openshift-sdn
spec:
groups:
- name: general.rules
- name: cluster-network-operator-sdn.rules
rules:
# note: all joins on kube_pod_* need a a "topk by (key) (1, <metric> )"
# otherwise you will generate query errors when kube_state_metrics is being
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
namespace: openshift-ovn-kubernetes
spec:
groups:
- name: general.rules
- name: cluster-network-operator-master.rules
rules:
- alert: NoRunningOvnMaster
annotations:
Expand Down
2 changes: 1 addition & 1 deletion bindata/network/ovn-kubernetes/alert-rules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
namespace: openshift-ovn-kubernetes
spec:
groups:
- name: general.rules
- name: cluster-network-operator-ovn.rules
rules:
- alert: NodeWithoutOVNKubeNodePodRunning
annotations:
Expand Down

0 comments on commit f8fb356

Please sign in to comment.